limit ancient pack budget for shrinking #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
approved these changes
Jul 19, 2024
|
All of CI has passed except for the one broken downstream projects test. Since this PR doesn't touch anything program-related, I think it is safe to merge. #2208 will fix the CI. An alternative would be to rebase and pick up this change once the PR is merged, but then this PR will need to go through all of CI again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Testing with skipping rewrites and ancient packing have resulted in a steady state where we have too many ancient storages that need to be 'shrunk'. These already large, ancient storages dominate the budget of a maximum of 10 ancient append vecs of ideal size. The result is that packing fails to make progress on keeping a limit on the number of ancient storages/roots.
Summary of Changes
Limit the shrink budget based on the overall limit of ideal storages to produce.
Fixes #